[1.9.x] Backport CA and test fixes #12038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca: use the real FSM operation in tests Fixed conflicts in tests.
…ondary ca: improve test coverage for RenewIntermediate
dnephin
added
the
pr/no-changelog
|
This pull request is being automatically deployed with Vercel (learn more). consul-ui-staging – ./ui🔍 Inspect: https://vercel.com/hashicorp/consul-ui-staging/GwZfSmj5cVmnyxmHBRJ4Ju2TtkC9 [Deployment for 0af407b canceled] |
github-actions
bot
added
the
theme/connect
This line was backported by automation, but it fails the build on this branch.
For some reason 1.9 seems to require an explicit Datacenter name making these RPC requests. In newer versions it works with the empty string.
kisunji
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #11780, includes #11721 to prevent most of the conflicts. I couldn't take the extra commit #12037 because there were too many differences. So instead I l had to leave out the
leaderRoutine.Wait()fix.