Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document .addr DNS domain in SRV responses #12056

Merged
merged 4 commits into from
Jan 19, 2022

Conversation

blake
Copy link
Member

@blake blake commented Jan 13, 2022

Document .addr DNS subdomain that can be returned in SRV response records.

Preview link

@blake blake added type/docs Documentation needs to be created/updated/clarified pr/do-not-merge PR cannot be merged in its current form. type/docs-cherrypick pr/no-changelog PR does not need a corresponding .changelog entry labels Jan 13, 2022
@blake blake self-assigned this Jan 13, 2022
@blake blake force-pushed the docs/srv-dns-addr-domain-7360 branch from ace8177 to d3d9145 Compare January 14, 2022 01:10
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging January 14, 2022 01:10 Inactive
@blake blake requested a review from a team January 14, 2022 01:26
@blake blake marked this pull request as ready for review January 14, 2022 01:26
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging January 14, 2022 06:55 Inactive
blake and others added 3 commits January 14, 2022 10:26
Initial draft for documenting .addr DNS subdomain.
Co-authored-by: Neena Pemmaraju <neena@hashicorp.com>
- Remove statement about `.addr` being added in 1.7.0. This was actually
  added in Consul 0.7.1.
- Correctly state when `addr` addresses are returned.
@blake blake force-pushed the docs/srv-dns-addr-domain-7360 branch from 2984759 to 113dc58 Compare January 14, 2022 20:10
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging January 14, 2022 20:10 Inactive
@blake blake added backport/1.11 and removed pr/do-not-merge PR cannot be merged in its current form. labels Jan 14, 2022
@blake blake added the event/consul-docs-day A day focused on improving Consul's documentation. Date: Jan 10, 2022. label Jan 19, 2022
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@blake blake merged commit 1495a1f into main Jan 19, 2022
@blake blake deleted the docs/srv-dns-addr-domain-7360 branch January 19, 2022 17:45
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/558382.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 1495a1f onto stable-website succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jan 19, 2022
Document `.addr` DNS subdomain that can be returned in SRV response
records.

Co-authored-by: Neena Pemmaraju <neena@hashicorp.com>
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 1495a1f onto release/1.11.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jan 19, 2022
Document `.addr` DNS subdomain that can be returned in SRV response
records.

Co-authored-by: Neena Pemmaraju <neena@hashicorp.com>
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 1495a1f onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jan 19, 2022
Document `.addr` DNS subdomain that can be returned in SRV response
records.

Co-authored-by: Neena Pemmaraju <neena@hashicorp.com>
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 1495a1f onto release/1.9.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jan 19, 2022
Document `.addr` DNS subdomain that can be returned in SRV response
records.

Co-authored-by: Neena Pemmaraju <neena@hashicorp.com>
@hc-github-team-consul-core
Copy link
Collaborator

🍒❌ Cherry pick of commit 1495a1f onto release/1.8.x failed! Build Log

blake added a commit that referenced this pull request Jan 19, 2022
Document `.addr` DNS subdomain that can be returned in SRV response
records.

Co-authored-by: Neena Pemmaraju <neena@hashicorp.com>
blake added a commit that referenced this pull request Jan 19, 2022
Document `.addr` DNS subdomain that can be returned in SRV response
records.

Co-authored-by: Neena Pemmaraju <neena@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event/consul-docs-day A day focused on improving Consul's documentation. Date: Jan 10, 2022. pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants