Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acl: remove ResolveTokenToIdentity #12166

Merged
merged 5 commits into from
Feb 1, 2022
Merged

acl: remove ResolveTokenToIdentity #12166

merged 5 commits into from
Feb 1, 2022

Commits on Jan 22, 2022

  1. acl: return a resposne from ResolveToken that includes the ACLIdentity 

    So that we can duplicate duplicate methods.
    @dnephin
    dnephin committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    a5e8af7 View commit details
    Browse the repository at this point in the history

  2. acl: remove ResolveTokenToIdentity 

    By exposing the AccessorID from the primary ResolveToken method we can
remove this duplication.
    @dnephin
    dnephin committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    edca8d6 View commit details
    Browse the repository at this point in the history

  3. acl: remove calls to ResolveIdentityFromToken 

    We already have an ACLResolveResult, so we can get the accessor ID from
it.
    @dnephin
    dnephin committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    e134e43 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. acl: Remove a call to aclAccessorID 

    I missed this on the first pass, we no longer need to look up this ID, because we have it
from the Authorizer.
    @dnephin
    dnephin committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    7a6e03c View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. acl: remove unused methods on fakes, and add changelog 

    Also document the metric that was removed in a previous commit.
    @dnephin
    dnephin committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    d363cc0 View commit details
    Browse the repository at this point in the history