Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating consul on k8s to remove known limitations of serverAdditionalDNSSans and serverAdditionalIPSans #12338

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

jmurret
Copy link
Member

@jmurret jmurret commented Feb 14, 2022

This limitation was enabled last week with hashicorp/consul-k8s#1020

@jmurret jmurret requested a review from a team as a code owner February 14, 2022 19:40
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Feb 14, 2022
@jmurret jmurret requested review from a team, kschoche and thisisnotashwin and removed request for a team February 14, 2022 19:41
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking that this is released?

@jmurret jmurret added the pr/no-changelog PR does not need a corresponding .changelog entry label Feb 14, 2022
@kschoche
Copy link
Contributor

Just checking that this is released?

good point, I think this needs to wait to go live until we release

@jmurret jmurret merged commit f956e66 into main Feb 23, 2022
@jmurret jmurret deleted the jm/ip-sans branch February 23, 2022 21:04
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/593798.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit f956e66 onto stable-website succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Feb 23, 2022
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit f956e66 onto release/1.11.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants