Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add multiport docs for K8s #12428

Merged
merged 2 commits into from
Feb 24, 2022
Merged

add multiport docs for K8s #12428

merged 2 commits into from
Feb 24, 2022

Conversation

ndhanushkodi
Copy link
Contributor

@ndhanushkodi ndhanushkodi commented Feb 23, 2022 •
edited
Loading

Add docs for the multiport workaround in K8s: hashicorp/consul-k8s#1012

Is the position of the doc ok as is or should it be a standalone page?

Currently it's been added to /docs/k8s/connect

@ndhanushkodi ndhanushkodi requested a review from a team as a code owner February 23, 2022 22:35
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Feb 23, 2022
@ndhanushkodi ndhanushkodi added pr/no-changelog PR does not need a corresponding .changelog entry type/docs-cherrypick type/docs Documentation needs to be created/updated/clarified and removed type/docs Documentation needs to be created/updated/clarified labels Feb 23, 2022
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@ndhanushkodi ndhanushkodi requested review from david-yu, a team, jmurret and thisisnotashwin and removed request for a team February 23, 2022 22:40
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging February 24, 2022 00:10 Inactive
@david-yu david-yu merged commit 00c7f4f into main Feb 24, 2022
@david-yu david-yu deleted the multiport-docs branch February 24, 2022 00:11
@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/594240.

@hc-github-team-consul-core
Copy link
Contributor

🍒✅ Cherry pick of commit 00c7f4f onto stable-website succeeded!

@hc-github-team-consul-core
Copy link
Contributor

🍒✅ Cherry pick of commit 00c7f4f onto release/1.11.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Feb 24, 2022
@ndhanushkodi @hc-github-team-consul-core
add multiport docs for K8s (#12428)
a4034d3 
* add multiport docs for K8s

* add formatting

Co-authored-by: David Yu <dyu@hashicorp.com>
hc-github-team-consul-core pushed a commit that referenced this pull request Feb 24, 2022
@ndhanushkodi @hc-github-team-consul-core
add multiport docs for K8s (#12428)
3a8ee19 
* add multiport docs for K8s

* add formatting

Co-authored-by: David Yu <dyu@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-yu david-yu david-yu approved these changes

@jmurret jmurret Awaiting requested review from jmurret

@thisisnotashwin thisisnotashwin Awaiting requested review from thisisnotashwin

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ndhanushkodi @hashicorp-ci @hc-github-team-consul-core @david-yu