Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catalog: compare node names case insensitively in more places #12444

Merged
merged 8 commits into from
Feb 24, 2022
Merged

catalog: compare node names case insensitively in more places #12444

merged 8 commits into from
Feb 24, 2022

Commits on Feb 24, 2022

  1. compare node names case insensitively in more places 

    Many places in consul already treated node names case insensitively.
The state store indexes already do it, but there are a few places that
did a direct byte comparison which have now been corrected.

One place of particular consideration is ensureCheckIfNodeMatches
which is executed during snapshot restore (among other places). If a
node check used a slightly different casing than the casing of the node
during register then the snapshot restore here would deterministically
fail. This has been fixed.

Primary approach:

    git grep -i "node.*[!=]=.*node" -- ':!*_test.go' ':!docs'
    git grep -i '\[[^]]*member[^]]*\]
    git grep -i '\[[^]]*\(member\|name\|node\)[^]]*\]' -- ':!*_test.go' ':!website' ':!ui' ':!agent/proxycfg/testing.go:' ':!*.md'
    @rboyer
    rboyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    9c5b379 View commit details
    Browse the repository at this point in the history

  2. changelog

    @rboyer
    rboyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    a60abbe View commit details
    Browse the repository at this point in the history

  3. Update .changelog/12444.txt 

    Co-authored-by: Matt Keeler <mkeeler@users.noreply.github.com>
    @rboyer @mkeeler
    rboyer and mkeeler authored Feb 24, 2022
    Configuration menu
    Copy the full SHA
    903087a View commit details
    Browse the repository at this point in the history

  4. update TestStructs_RegisterRequest_ChangesNode

    @rboyer
    rboyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    02766c0 View commit details
    Browse the repository at this point in the history

  5. edit TestNode_IsSame

    @rboyer
    rboyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    f5c965b View commit details
    Browse the repository at this point in the history

  6. update TestStructs_ServiceNode_IsSameService

    @rboyer
    rboyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    5654b2e View commit details
    Browse the repository at this point in the history

  7. update TestStructs_HealthCheck_IsSame

    @rboyer
    rboyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    0bdcab5 View commit details
    Browse the repository at this point in the history

  8. update tests for command/rtt

    @rboyer
    rboyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    707d097 View commit details
    Browse the repository at this point in the history