Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes consul-migrate for 0.6 #1309

Merged
merged 5 commits into from
Oct 15, 2015
Merged

Removes consul-migrate for 0.6 #1309

merged 5 commits into from
Oct 15, 2015

Conversation

ryanuber
Copy link
Member

Removes the built-in migration utility for the transition from LMDB->BoltDB. The utility can still be used stand-alone as a CLI utility. This also makes Consul servers refuse to start if the mdb dir is found in the data-dir to guard non-migrated 0.5.x servers from starting with an empty data set.

if _, err := os.Stat(mdbPath); !os.IsNotExist(err) {
c.Ui.Error(fmt.Sprintf("CRITICAL: Deprecated data folder found at %q!", mdbPath))
c.Ui.Error("Consul will refuse to boot with this directory present.")
c.Ui.Error("See https://consul.io/docs/upgrade-specific.html for more information.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well update that here, too :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog is a legit suggestion, too - this is a breaking-ish-change.

@slackpad
Copy link
Contributor

LGTM

ryanuber added a commit that referenced this pull request Oct 15, 2015
@ryanuber ryanuber merged commit d6af59c into master Oct 15, 2015
@ryanuber ryanuber deleted the f-remove-migrate branch October 15, 2015 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants