-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Health checks windows service #13388
Merged
kisunji
merged 25 commits into
hashicorp:main
from
deblasis:feature/health-checks_windows_service
Oct 17, 2022
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
4de260f
docs: added os_service
deblasis b59c19b
feat: windows service health checks
deblasis 2cd5201
chore: changelog
deblasis af083cc
tests: added syscall mocking and tests for Check_OSService
deblasis 28f19e4
tests: removed redundant probe test
deblasis 06304bf
lint: conversion
deblasis ab611ea
Merge remote-tracking branch 'hashicorp/main' into feature/health-che…
deblasis 5dee555
Merge remote-tracking branch 'hashicorp/main' into feature/health-che…
deblasis 61f6fa9
Update website/content/docs/discovery/checks.mdx
deblasis f0f0421
Update website/content/api-docs/agent/check.mdx
deblasis f634e36
fix(OSServiceCheck): fixes following code-review
deblasis f3437ea
Merge remote-tracking branch 'hashicorp/main' into feature/health-che…
deblasis 1d5bb02
docs(checks): updated OSService docs to match new format
deblasis b391392
Update website/content/docs/discovery/checks.mdx
deblasis fd2dd89
Update website/content/docs/discovery/checks.mdx
deblasis c0d647d
fix(agent): removed redundant check on prev. running check
deblasis 26cc56b
fix(agent): removed redundant code in docker check as well
deblasis 60c7c83
Merge remote-tracking branch 'hashicorp/main' into feature/health-che…
deblasis fc0dd92
fix(agent): uninitialized map panic error
deblasis f440966
fix(checks): os_service lifecycle bugfix
deblasis 5719fd6
fix(checks): os_service OK message in output
deblasis 461b42e
fix(check): added missing OSService props
deblasis a39d034
Update website/content/api-docs/agent/check.mdx
deblasis 5bba2a3
Update website/content/docs/ecs/configuration-reference.mdx
deblasis 5f99f57
Update website/content/api-docs/agent/check.mdx
deblasis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
agent: windows service health check |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see
Timeout
being used anywhere. Is it worth implementing a timeout error? Unlike gRPC or script checks I would assume OS service polling shouldn't take too long and it's not worth enforcing.