-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement WaitForResult
in tests to eliminate race conditions
#136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is a great way to do it. Great work! |
Thanks, yeah it seem to work quite fine on Travis, just some files left to patch. Ping #131. |
I'm gathering strength to deal with the last failing tests, just 8 more I'm aware of. |
@tiwilliam Awesome work. Thanks so much, it'll be great to have the tests be more reliable. |
@tiwilliam Actually, I'm going to merge this in now! We can port the tests in master! |
armon
added a commit
that referenced
this pull request
May 16, 2014
WIP: Proof of concept using `WaitForResult` in tests
Cool! |
tiwilliam
changed the title
WIP: Proof of concept using
Implement May 16, 2014
WaitForResult
in testsWaitForResult
in tests to eliminate race conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative solution to using sleeps in test.
WaitForResult
will retry the test call every 10ms and timeout after 5s. A sample test call look like this: