Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSS] proxycfg: terminate stream on irrecoverable errors #14144

Merged
merged 1 commit into from
Aug 23, 2022

Commits on Aug 11, 2022

  1. proxycfg: terminate stream on irrecoverable errors

    This is the OSS portion of enterprise PR 2339.
    
    It improves our handling of "irrecoverable" errors in proxycfg data sources.
    
    The canonical example of this is what happens when the ACL token presented by
    Envoy is deleted/revoked. Previously, the stream would get "stuck" until the
    xDS server re-checked the token (after 5 minutes) and terminated the stream.
    
    Materializers would also sit burning resources retrying something that could
    never succeed.
    
    Now, it is possible for data sources to mark errors as "terminal" which causes
    the xDS stream to be closed immediately. Similarly, the submatview.Store will
    evict materializers when it observes they have encountered such an error.
    boxofrad committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    7eeaeca View commit details
    Browse the repository at this point in the history