Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RemoveEmptyTags in API client #14244

Closed
wants to merge 2 commits into from
Closed

Add support for RemoveEmptyTags in API client #14244

wants to merge 2 commits into from

Conversation

remilapeyre
Copy link
Contributor

This change is needed to implement support for RemoveEmptyTags in the Terraform provider.

@github-actions github-actions bot added the theme/api Relating to the HTTP API interface label Aug 17, 2022
@remilapeyre remilapeyre mentioned this pull request Aug 17, 2022
Merged
@github-actions
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Oct 17, 2022
@github-actions
Copy link

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.

@github-actions github-actions bot closed this Nov 17, 2022
@remilapeyre
Copy link
Contributor Author

This is not stale.

@mkeeler mkeeler reopened this Jan 30, 2023
mkeeler
mkeeler approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For others, this option was already available internally or if API consumers would use the HTTP API directly and not through the Go client. This just adds it to the api modules definition of the struct.

dhiaayachi
dhiaayachi approved these changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhiaayachi dhiaayachi enabled auto-merge (squash) January 31, 2023 15:17
@dhiaayachi dhiaayachi disabled auto-merge January 31, 2023 15:33
@dhiaayachi dhiaayachi mentioned this pull request Jan 31, 2023
Merged
@dhiaayachi
Copy link
Collaborator

Closed in favour of #16113

@dhiaayachi dhiaayachi closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeeler mkeeler mkeeler approved these changes

@dhiaayachi dhiaayachi dhiaayachi approved these changes

Assignees
No one assigned
Labels
meta/stale Automatically flagged for inactivity by stalebot pr/no-metrics-test theme/api Relating to the HTTP API interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remilapeyre @dhiaayachi @mkeeler