Adds a retry capability to lock monitors in the API client. #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
slackpad
added a commit
that referenced
this pull request
Dec 1, 2015
Adds a retry capability to lock monitors in the API client.
| // counter if service is restored. | ||
| if retries > 0 && strings.Contains(err.Error(), serverError) { | ||
| time.Sleep(l.opts.MonitorRetryTime) | ||
| retries-- |
There was a problem hiding this comment.
I feel like the retry limit should be consecutive failures not cumulative. e.g. if we have one retry and then it works, we should reset the request count otherwise we will eventually always hit zero given enough time.
There was a problem hiding this comment.
@armon - agree! I had a bug initially that did this because I didn't make the retries non-blocking. As-as it should be consecutive, though. When it jumps to WAIT it always resets the retries back up to the max.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a retry for 500 errors to the lock monitor so they don't immediately sense a problem and think they've lost the lock if there's a leader election or other brief Consul service interruption. This will address #1162 from the API client side, though we will still need to update
consul lockitself.With a Vault test setup with retries enabled I was able to observe it riding out a leader election without causing a simultaneous Vault leader election (though there were still expected Vault errors from other Consul requests that failed during the flap).