Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add OpenShift CNI to list of install options for kubernetes #14780

Closed
wants to merge 1 commit into from

Conversation

curtbushko
Copy link
Contributor

Description

Describe why you're making this change, in plain English.

When consul-k8s is released with 0.49.0, around Sept 29th, there will now be support for using the consul-cni plugin on OpenShift.

This change adds that information to the consul-k8s install doc.

Testing & Reproduction steps

Ran the container locally and validated the changes.

Links

CNI: Add support for OpenShift and Multus

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

@curtbushko curtbushko requested a review from david-yu September 28, 2022 14:04
@curtbushko curtbushko requested a review from a team as a code owner September 28, 2022 14:04
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Sep 28, 2022
@curtbushko curtbushko added the pr/no-changelog PR does not need a corresponding .changelog entry label Sep 28, 2022
@curtbushko curtbushko changed the title Add OpenShift CNI to list of install options for kubernetes Docs: Add OpenShift CNI to list of install options for kubernetes Sep 28, 2022
Copy link
Contributor

@david-yu david-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@david-yu
Copy link
Contributor

Btw if these go-tests are blocking you from merging due to flakiness I think you'll need to rename your branch to docs/cni-openshift or something with a docs/ prefix to skip those go-tests. This will mean a new PR will be required though.

@curtbushko curtbushko closed this Sep 28, 2022
@curtbushko curtbushko deleted the curtbushko/cni-openshift-docs branch September 28, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants