ent changelog for peer in virtual dns queries #15351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How would I make this changelog go into 1.14? The enterprise change was backported to 1.14. backport label? |
ndhanushkodi
requested review from
hc-github-team-consul-core,
erichaberkorn and
hashi-derek
and removed request for
hc-github-team-consul-core
hashi-derek
reviewed
Nov 14, 2022
| @@ -0,0 +1,3 @@ | |||
| ```release-note:improvement | |||
| dns/peering: **(Enterprise Only)** Support addresses in the formats <servicename>.virtual.<namespace>.ns.<partition>.ap.<peername>.peer.consul and <servicename>.virtual.<partition>.ap.<peername>.peer.consul. This longer form address that allows specifying `.peer` would need to be used for tproxy DNS requests made within non-default partitions for imported services. | |||
There was a problem hiding this comment.
Maybe we should simplify this comment for people reading through a list of changelog entries? It's kinda long.
"Support DNS queries for imported peer services in non-default partitions by adding a new .peer identifier."
ndhanushkodi
added
the
pr/no-changelog
hashi-derek
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.