Adding singleton option to DNS for getaddrinfo bug. #1583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a relatively small change. I think it failed the check because of other issues you were having with Travis timeout recently. |
|
@fusiondog I think so as well. Do you mind adding a note about this to the docs as well? I'm happy to do that, too - just let me know. |
|
@fusiondog Thank you for your PR. I'm going to take PR and update it so that an administrator can specify an |
|
@sean- Would the int be able to exceed the default 3 results? The doc update should probably still make a point of the getaddrinfo bug and that using the setting at value 1 is needed to resolve. |
sean-
added a commit
that referenced
this pull request
Feb 12, 2016
Based on work done by @fusiondog in #1583, extend the concept to use an integer instead of a boolean. Fixes: #1583 && #1481
sean-
added a commit
that referenced
this pull request
Mar 30, 2016
Based on work done by @fusiondog in #1583, extend the concept to use an integer instead of a boolean. Fixes: #1583 && #1481
|
This has been committed in #1712, thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix for a problem in some versions of glibc