-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add provider ca support for approle auth-method #16259
Conversation
c7e924e
to
da46edc
Compare
da46edc
to
56ac990
Compare
Note that there is a failing test that doesn't test what it seems like it should and makes me unsure about the fields that are required as part of this. Our docs say the role_id_file_path is a require parameter but we have a test that has the role_id and secret_id set directly in the params. I'm going to look at this more tomorrow, but wanted to drop a note in case a reviewer drops by. |
7a14976
to
e186242
Compare
Figured out what is going on with that test. Here is the comment I wrote (on the K8s support PR, #16262) to explain what is going on in regard to this... // Note the authMethod's parameters (Params) is populated from a free form map |
84e26a5
to
99b8aef
Compare
b3b3229
to
4574684
Compare
Adds support for the approle auth-method. Only handles using the approle role/secret to auth and it doesn't support the agent's extra management configuration options (wrap and delete after read) as they are not required as part of the auth (ie. they are vault agent things).
4574684
to
7cc4d2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Adds support for the approle auth-method. Only handles using the approle role/secret to auth and it doesn't support the agent's extra management configuration options (wrap and delete after read) as they are not required as part of the auth (ie. they are vault agent things).
PR Checklist