Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Documentation update: Adding K8S clusters to external Consul servers into stable-website #16379

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16285 to be assessed for backporting due to the inclusion of the label type/docs-cherrypick.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

The documentation on adding K8S clusters to external Consul servers needed to include a few details around installation with Consul Dataplane.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Overview of commits

Sorry, something went wrong.

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/join-k8s-to-external-consul-servers/equally-whole-raccoon branch 2 times, most recently from 3b5b757 to c08ce29 Compare February 22, 2023 20:27
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 22, 2023

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • Ranjandas
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Sorry, something went wrong.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@david-yu david-yu marked this pull request as ready for review February 22, 2023 20:31
@david-yu david-yu requested a review from a team as a code owner February 22, 2023 20:31
@david-yu david-yu merged commit 5a2bbcd into stable-website Feb 22, 2023
@david-yu david-yu deleted the backport/docs/join-k8s-to-external-consul-servers/equally-whole-raccoon branch February 22, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants