Backport of docs: improve upgrade path guidance into release/1.15.x #16927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles for bugs (#16307) * Update bug_report.md
* Fix hostname alignment checks for HTTPRoutes
* Add defensive guard to make some tests less flaky and panic less * Do the actual fix
…onfigEntries (#16304) * Add stricter validation and some normalization code for API Gateway ConfigEntries
… inline text for instructions (#16313) * Update bug_report.md * Update feature_request.md * Update ui_issues.md * Update pull_request_template.md
* security: update go to 1.20.1
Protobuf Refactoring for Multi-Module Cleanliness This commit includes the following: Moves all packages that were within proto/ to proto/private Rewrites imports to account for the packages being moved Adds in buf.work.yaml to enable buf workspaces Names the proto-public buf module so that we can override the Go package imports within proto/buf.yaml Bumps the buf version dependency to 1.14.0 (I was trying out the version to see if it would get around an issue - it didn't but it also doesn't break things and it seemed best to keep up with the toolchain changes) Why: In the future we will need to consume other protobuf dependencies such as the Google HTTP annotations for openapi generation or grpc-gateway usage. There were some recent changes to have our own ratelimiting annotations. The two combined were not working when I was trying to use them together (attempting to rebase another branch) Buf workspaces should be the solution to the problem Buf workspaces means that each module will have generated Go code that embeds proto file names relative to the proto dir and not the top level repo root. This resulted in proto file name conflicts in the Go global protobuf type registry. The solution to that was to add in a private/ directory into the path within the proto/ directory. That then required rewriting all the imports. Is this safe? AFAICT yes The gRPC wire protocol doesn't seem to care about the proto file names (although the Go grpc code does tack on the proto file name as Metadata in the ServiceDesc) Other than imports, there were no changes to any generated code as a result of this.
* new docs for consul and consul-k8s troubleshoot command * add changelog * add troubleshoot command * address comments, and update cli output to match * revert changes to troubleshoot upstreams, changes will happen in separate pr * Update .changelog/16284.txt Co-authored-by: Nitya Dhanushkodi <nitya@hashicorp.com> * address comments * update trouble proxy output * add missing s, add required fields in usage --------- Co-authored-by: Nitya Dhanushkodi <nitya@hashicorp.com>
* Update all templates.
* fix: add tls config to unix socket when https is used * unit test and changelog
* [API Gateway] Validate listener name is not empty * Update docstrings and test
#16339) Prior to this commit, all peer services were transmitted as connect-enabled as long as a one or more mesh-gateways were healthy. With this change, there is now a difference between typical services and connect services transmitted via peering. A service will be reported as "connect-enabled" as long as any of these conditions are met: 1. a connect-proxy sidecar is registered for the service name. 2. a connect-native instance of the service is registered. 3. a service resolver / splitter / router is registered for the service name. 4. a terminating gateway has registered the service.
* [API Gateway] Fix targeting service splitters in HTTPRoutes * Fix test description
* [API Gateway] Various fixes for Config Entry fields * simplify logic per PR review
…netes (#16360) * Update existing docs from Consul API Gateway -> API Gateway for Kubernetes * Update page header to reflect page title change * Update nav title to match new page title
* Placeholder commit for changelog entry * Add changelog entry announcing support for API Gateway on VMs * Adjust casing
…d routes and gateways (#16377)
* add support for prefixes in the config tree * fix to use default config when the prefix have no config
…16285) * Remove Consul Client installation option With Consul-K8S 1.0 and introduction of Consul-Dataplane, K8S has the option to run without running Consul Client agents. * remove note referring to the same documentation * Added instructions on the use of httpsPort when servers are not running TLS enabled * Modified titile and description
* Add docs for usage endpoint and command
hc-github-team-consul-core
force-pushed
the
backport/docs/improve-upgrade-instructions/informally-relieved-grouper
branch
from
f58900f
to
34a1543
Compare
hc-github-team-consul-core
requested review from
dekimsey and
emilymianeil
and removed request for
a team
hc-github-team-consul-core
force-pushed
the
backport/docs/improve-upgrade-instructions/informally-relieved-grouper
branch
from
c0aad46
to
0ee8f83
Compare
github-team-consul-core-pr-approver
approved these changes
Apr 7, 2023
github-actions
bot
added
pr/dependencies
hc-github-team-consul-core
deleted the
backport/docs/improve-upgrade-instructions/informally-relieved-grouper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16925 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Description
The current upgrade instructions have the following weaknesses:
Preview
Revised version jump instructions page
Overview of commits