Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of snapshot: some improvments to the snapshot process into release/1.15.x #17277

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17236 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.


Description

snapshot: some improvments to the snapshot process

  • Add raft to the snapshot logger because the log messages are from raft package, making it consistent with other snapshot logs like starting snapshot up to, which are from the raft package as well. Also it allows users know where to search for the logger message
// before
2023-05-08T10:10:19.954-0400 [INFO]  agent.server.raft: starting snapshot up to: index=30
2023-05-08T10:10:19.954-0400 [INFO]  agent.server.snapshot: creating new snapshot: path=/tmp/dc-2-consul-server-1/raft/snapshots/3-30-1683555019954.tmp
2023-05-08T10:10:19.967-0400 [INFO]  agent.server.raft: snapshot complete up to: index=30

// after
2023-05-08T10:04:20.361-0400 [INFO]  agent.server.raft: starting snapshot up to: index=25
2023-05-08T10:04:20.361-0400 [INFO]  agent.server.raft.snapshot: creating new snapshot: path=/tmp/dc-2-consul-server-1/raft/snapshots/2-25-1683554660361.tmp
2023-05-08T10:04:20.382-0400 [INFO]  agent.server.raft: snapshot complete up to: index=25
2023-05-08T10:04:20.382-0400 [INFO]  agent.server: creating temporary file of snapshot: path=/var/folders/c0/0_4qftyd47g8bkq_4_5dpw4m0000gn/T/snapshot3125735996
  • Print out the path of the temp snapshot file for trouble shooting

  • Update the doc a bit

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core requested a review from a team as a code owner May 9, 2023 19:29
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/minor-update-snapshot-logger/illegally-aware-jackass branch from 608d03d to 099aebf Compare May 9, 2023 19:29
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/minor-update-snapshot-logger/illegally-aware-jackass branch from 24e6525 to f48f1de Compare May 9, 2023 19:29
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label May 9, 2023
@huikang huikang force-pushed the backport/minor-update-snapshot-logger/illegally-aware-jackass branch from 05ef3d3 to 780cdd0 Compare May 9, 2023 20:36
@hc-github-team-consul-core hc-github-team-consul-core merged commit 1aa4b3b into release/1.15.x May 9, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/minor-update-snapshot-logger/illegally-aware-jackass branch May 9, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants