Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to links in services overview description paragraph #17406

Merged
merged 1 commit into from
May 18, 2023
Merged

updates to links in services overview description paragraph #17406

merged 1 commit into from
May 18, 2023

Conversation

trujillo-adam
Copy link
Contributor

Description

Small tweaks to the description block on the Services overview page. The description now points to additional overview information about how services work in SM and SM on K8s.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@trujillo-adam trujillo-adam added type/docs Documentation needs to be created/updated/clarified pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test backport/1.14 backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. labels May 18, 2023
@trujillo-adam trujillo-adam marked this pull request as ready for review May 18, 2023 16:44
@trujillo-adam trujillo-adam requested a review from a team as a code owner May 18, 2023 16:44
boruszak
boruszak approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trujillo-adam trujillo-adam merged commit d20e3df into main May 18, 2023
@trujillo-adam trujillo-adam deleted the docs/services-overview-tweaks branch May 18, 2023 16:51
This was referenced May 18, 2023
Merged
Merged
trujillo-adam added a commit that referenced this pull request May 18, 2023
@trujillo-adam
updates to links in services overview description paragraph (#17406)
78c226a
trujillo-adam added a commit that referenced this pull request May 18, 2023
@hc-github-team-consul-core @trujillo-adam
Backport of updates to links in services overview description paragra…
7daa89a 
…ph into release/1.14.x (#17407)

* no-op commit due to failed cherry-picking

* updates to links in services overview description paragraph (#17406)

---------

Co-authored-by: temp <temp@hashicorp.com>
Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
nickethier pushed a commit that referenced this pull request May 26, 2023
@trujillo-adam @nickethier
updates to links in services overview description paragraph (#17406)
0bf35a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boruszak boruszak boruszak approved these changes

Assignees
No one assigned
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trujillo-adam @boruszak