Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add necessary plumbing to implement per server ip based rate limiting #17436

Merged
merged 1 commit into from
May 23, 2023
Merged

Add necessary plumbing to implement per server ip based rate limiting #17436

merged 1 commit into from
May 23, 2023

Conversation

dhiaayachi
Copy link
Collaborator

Description

This adds the plumbing necessary to be able to not rate limit requests coming from other servers at the IP based rate limiting (enterprise feature).

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@dhiaayachi dhiaayachi added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels May 23, 2023
@dhiaayachi dhiaayachi requested a review from xwa153 May 23, 2023 18:03
xwa153
xwa153 approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@xwa153 xwa153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look Great! Thanks! 🚀

@dhiaayachi dhiaayachi merged commit f526dfd into main May 23, 2023
@dhiaayachi dhiaayachi deleted the rate-limiter-ip/fix_not_rate_servers branch May 23, 2023 19:37
nickethier pushed a commit that referenced this pull request May 26, 2023
@dhiaayachi @nickethier
add necessary plumbing to implement per server ip based rate limiting (…
7ae36e5 
…#17436)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwa153 xwa153 xwa153 approved these changes

Assignees
No one assigned
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhiaayachi @xwa153