Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of add enterprise notes for IP-based rate limits into release/1.16.x #17714

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17711 to be assessed for backporting due to the inclusion of the label backport/1.16.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@trujillo-adam
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "6ded13acb14f9f483ea7129ad30f1f10532d2f3d", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Description

This PR flags the IP-based request rate limiting functionality as Consul Enterprise. The usage docs, configuration entry, and CE matrix have been updated.

PR Checklist

  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/add-enterprise-note-rate-limits-by-ip/sharply-busy-porpoise branch from 93f4150 to 5f23dc0 Compare June 13, 2023 21:29
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/add-enterprise-note-rate-limits-by-ip/sharply-busy-porpoise branch from 90786f0 to 93cb534 Compare June 13, 2023 21:29
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Jun 13, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@trujillo-adam trujillo-adam marked this pull request as ready for review June 13, 2023 21:44
@trujillo-adam trujillo-adam requested a review from a team as a code owner June 13, 2023 21:44
@trujillo-adam trujillo-adam merged commit 277a844 into release/1.16.x Jun 13, 2023
@trujillo-adam trujillo-adam deleted the backport/docs/add-enterprise-note-rate-limits-by-ip/sharply-busy-porpoise branch June 13, 2023 21:44
@david-yu
Copy link
Contributor

@trujillo-adam It looks like it didn't cherry pick all your commits.

@trujillo-adam trujillo-adam restored the backport/docs/add-enterprise-note-rate-limits-by-ip/sharply-busy-porpoise branch June 14, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants