Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Allow service identity tokens the ability to read jwt-providers into release/1.16.x #17896

Merged

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #17893 to be assessed for backporting due to the inclusion of the label backport/1.16.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@roncodingenthusiast
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "478beccf2d33953a7d03682ea78ce236ea97e6e6", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Description

  • This PR allows service identity tokens the ability to read jwt providers. This is necessary because before writing an intention that referenced a jwt-provider, there is a validation to ensure that jwt-provider exist.
  • Prior to this PR, if the token didn't have mesh:read permission, it will not be able to access the provider hence failing to write any intentions referencing jwt providers due to the validation mentioned above

Overview of commits

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul June 27, 2023 16:08 Inactive
@roncodingenthusiast roncodingenthusiast marked this pull request as ready for review June 27, 2023 16:29
@roncodingenthusiast roncodingenthusiast force-pushed the backport/issue-17886/lightly-moral-seal branch from 4170567 to 6830751 Compare June 27, 2023 16:52
@roncodingenthusiast roncodingenthusiast enabled auto-merge (squash) June 27, 2023 16:53
@roncodingenthusiast roncodingenthusiast merged commit c689713 into release/1.16.x Jun 27, 2023
@roncodingenthusiast roncodingenthusiast deleted the backport/issue-17886/lightly-moral-seal branch June 27, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants