Backport of [NET-4876] docs - update upgrade index page to not recommend consul leave. into release/1.16.x #18110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/jm/docs/friendly-warm-quail
branch
2 times, most recently
from
0d68ebf to
915bb9c
Compare
github-team-consul-core-pr-approver
approved these changes
Jul 12, 2023
github-actions
bot
added
the
type/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18100 to be assessed for backporting due to the inclusion of the label backport/1.16.
The below text is copied from the body of the original PR.
Description
consul leave is bad during upgrades because the leaving server will disconnect and think there is no leader and initiate a series of new elections, but cannot communicate with others. When it comes up, its term is much higher than the leader and the leader will detect this and step down. Having the leader change is bad when you are trying to guarantee that the leader is upgraded last.
We've already changed this on the general upgrade process page. This is another instance we just found
Overview of commits