Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service-defaults doc with upstreamConfig 1.14 change #18170

Closed
wants to merge 1 commit into from

Conversation

markcampv
Copy link
Contributor

Description

To help explain 1.14 changes in case operators run into protocol issues when upgrading.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

To help explain 1.14 changes in case operators run into protocol issues when upgrading.
@markcampv markcampv requested a review from a team as a code owner July 18, 2023 16:26
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Jul 18, 2023
@markcampv markcampv changed the title Update service-defaults.mdx Update service-defaults doc with upstreamConfig 1.14 change Jul 18, 2023
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional information, but I think the details about the changes between versions are better suited for the release notes and change log. We should update the UpstreamConfig.Overrides[].Limits description with the behavior you talk about because, I understand correctly, that is the relevant field.

@github-actions
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Sep 30, 2023
Copy link

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.

@github-actions github-actions bot closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta/stale Automatically flagged for inactivity by stalebot type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants