Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Revert "NET-4996 - filter go-tests and test-integration workflows from running on docs only and ui only changes" into release/1.16.x #18253

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #18248 to be assessed for backporting due to the inclusion of the label backport/1.16.

The below text is copied from the body of the original PR.


Reverts #18236

Our branch protection rules require that the last job in each of these two workflows pass. So if they don't run, GH does not figure out why, it just blocks the PR based on the GitHub check is not complete.
Screenshot 2023-07-24 at 9 04 56 AM

This is GitHub's guidance:

Warning: If a workflow is skipped due to path filtering, branch filtering or a commit message, then checks associated with that workflow will remain in a "Pending" state. A pull request that requires those checks to be successful will be blocked from merging.

For this reason you should not use path or branch filtering to skip workflow runs if the workflow is required. For more information, see "Skipping workflow runs" and "Required workflows."

If, however, a job within a workflow is skipped due to a conditional, it will report its status as "Success". For more information, see "Using conditions to control job execution."


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/revert-18236-jm/NET-4996/constantly-infinite-kite branch 2 times, most recently from ca30dc0 to b861fef Compare July 24, 2023 16:06
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) July 24, 2023 16:06
@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Jul 24, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core hc-github-team-consul-core merged commit 583a3c1 into release/1.16.x Jul 24, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/revert-18236-jm/NET-4996/constantly-infinite-kite branch July 24, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants