Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [CC-5718] Remove HCP token requirement during bootstrap #18289

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

jjacobson93
Copy link
Contributor

@jjacobson93 jjacobson93 commented Jul 26, 2023

Backport (manual!)

The below text is copied from the body of the original PR.


Description

We are removing the requirement for HCP to provide Consul with a management token to support read-only tokens. This changes the validations to allow for a management token to be missing/ignored during bootstrapping with HCP.

Links

OSS PR
Ticket
RFC

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jjacobson93 jjacobson93 added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Jul 26, 2023
@jjacobson93 jjacobson93 requested review from loshz and lornasong July 26, 2023 16:12
@loshz loshz enabled auto-merge (squash) July 26, 2023 16:25
@jjacobson93 jjacobson93 force-pushed the jer/ccm-read-only-squashed-1.14.x branch from 27f487f to d0b546a Compare July 26, 2023 16:33
Copy link
Member

@lornasong lornasong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compared with #18140 and they look the same to me!

@loshz loshz merged commit aebc520 into release/1.14.x Jul 26, 2023
@loshz loshz deleted the jer/ccm-read-only-squashed-1.14.x branch July 26, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants