Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesh: add validation for the new pbmesh resources #18410

Merged
merged 16 commits into from
Aug 22, 2023
Prev Previous commit
Next Next commit
remove todo
rboyer committed Aug 21, 2023
commit a37a7ea03da178800de755ef12bc4001943dba03
2 changes: 0 additions & 2 deletions internal/mesh/internal/types/http_route.go
Original file line number Diff line number Diff line change
@@ -98,8 +98,6 @@ func ValidateHTTPRoute(res *pbresource.Resource) error {
}
}

// TODO(rb): port a bunch of validation from ServiceRouterConfigEntry.Validate

for j, match := range rule.Matches {
wrapMatchErr := func(err error) error {
return wrapRuleErr(resource.ErrInvalidListElement{