Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to latest buf v1.26.0 #18426

Merged
merged 1 commit into from
Aug 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ GO_MODULES := $(shell find . -name go.mod -exec dirname {} \; | grep -v "proto-g
###
GOLANGCI_LINT_VERSION='v1.51.1'
MOCKERY_VERSION='v2.20.0'
BUF_VERSION='v1.14.0'
BUF_VERSION='v1.26.0'

PROTOC_GEN_GO_GRPC_VERSION="v1.2.0"
MOG_VERSION='v0.4.0'
Expand Down
2 changes: 2 additions & 0 deletions proto/buf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# SPDX-License-Identifier: MPL-2.0

version: v1
deps:
- buf.build/hashicorp/consul
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a result of a new warning during make proto or make proto-lint:

WARN	bufimagebuild	File "private/pboperator/operator.proto" imports "annotations/ratelimit/ratelimit.proto", which is not found in your local files or direct dependencies, but is found in local workspace module "buf.build/hashicorp/consul". Declare dependency "buf.build/hashicorp/consul" in the deps key in buf.yaml.
WARN	bufimagebuild	File "private/pbpeering/peering.proto" imports "annotations/ratelimit/ratelimit.proto", which is not found in your local files or direct dependencies, but is found in local workspace module "buf.build/hashicorp/consul". Declare dependency "buf.build/hashicorp/consul" in the deps key in buf.yaml.
WARN	bufimagebuild	File "private/pbpeerstream/peerstream.proto" imports "annotations/ratelimit/ratelimit.proto", which is not found in your local files or direct dependencies, but is found in local workspace module "buf.build/hashicorp/consul". Declare dependency "buf.build/hashicorp/consul" in the deps key in buf.yaml.
WARN	bufimagebuild	File "private/pbstorage/raft.proto" imports "annotations/ratelimit/ratelimit.proto", which is not found in your local files or direct dependencies, but is found in local workspace module "buf.build/hashicorp/consul". Declare dependency "buf.build/hashicorp/consul" in the deps key in buf.yaml.
WARN	bufimagebuild	File "private/pbstorage/raft.proto" imports "pbresource/resource.proto", which is not found in your local files or direct dependencies, but is found in local workspace module "buf.build/hashicorp/consul". Declare dependency "buf.build/hashicorp/consul" in the deps key in buf.yaml.
WARN	bufimagebuild	File "private/pbsubscribe/subscribe.proto" imports "annotations/ratelimit/ratelimit.proto", which is not found in your local files or direct dependencies, but is found

lint:
use:
- DEFAULT
Expand Down
2 changes: 1 addition & 1 deletion proto/private/pbsubscribe/subscribe.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.