Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch all client nodes in dc2 to dataplane [NET-4299] #18608
switch all client nodes in dc2 to dataplane [NET-4299] #18608
Changes from 8 commits
868b727
f13b60e
7324ad6
2972b7e
7016acb
946fa73
c6ac290
0b0b9ba
d176eda
17f6ef5
fcb531d
ee3df2a
6355264
a511e11
54424a1
cc85121
fb1cf05
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I don't know what these do or if they're necessary, but
consul connect envoy -mesh-gateway
set them on registration.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The no default bind one will not bind to the main service address and the bind tagged addrs one then instructs it to bind envoy listeners to all the tagged addrs instead.
You could omit the main service addr form the tagged addresses and use the combination by not specifying the no default bind attribute. Or if you are in k8s then you just bind to the services addr (pod address) and ignore all the tagged addrs.
Basically, the binding of a mgw to specific addrs and ports is very flexible and controlled by these proxy config settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it being set in agentful mode?
Looking at the proxy config code I would expect node tagged addresses to generally be ignored for all proxies.
I think the only way to use tagged addresses for service mesh is to set the services tagged addresses like you have done here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared with an agentful mgw in DC1, I see that it has both
TaggedAddresses
andServiceTaggedAddresses
filled. Compared with an agentful service node in DC1, onlyTaggedAddresses
. Agentless service in DC2 has neither(Service)TaggedAddresses
, onlyAddress
andServiceAddress
(which makes some sense since it only has a LAN connection).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are all unrecoverable errors, so I just panic