Backport of Update base ref property name into release/1.16.x #18929
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18851 to be assessed for backporting due to the inclusion of the label backport/1.16.
🚨
The person who merged in the original PR is:
@NiniOak
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
PROBLEM
We found a bug where on pull request merge, the following error was returned by the
filter_changed_files_go_test.sh
See example here
SOLUTION
Update the
conditional-skip
job with a step to conditional check the github event,pull_request merged
, set GitHub branch value togithub.ref_name
pull_request
event, set GitHub branch value togithub.head_ref
Update the
filter_changed_files_go_test.sh
script to fail on script error and set the default behaviour to trigger CI, the previous behaviour was to skip CI.Testing & Reproduction steps
CI skipping tests where all changes are from skipped directories
CI running test workflows by default
Links
PR Checklist
Overview of commits