-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of Adds PassiveHealthCheck Fields to ServiceDefaults and IngressGateway into release/1.16.x #18947
Merged
missylbytes
merged 3 commits into
release/1.16.x
from
backport/net-5164-update-docs-with-passive-health-check/curiously-eminent-mammoth
Sep 22, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/net-5164-update-docs-with-passive-health-check/curiously-eminent-mammoth
branch
2 times, most recently
from
September 21, 2023 16:55
eec93a3
to
8d560ea
Compare
github-team-consul-core-pr-approver
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto approved Consul Bot automated PR
missylbytes
force-pushed
the
backport/net-5164-update-docs-with-passive-health-check/curiously-eminent-mammoth
branch
from
September 22, 2023 13:34
589ae23
to
d837059
Compare
missylbytes
force-pushed
the
backport/net-5164-update-docs-with-passive-health-check/curiously-eminent-mammoth
branch
from
September 22, 2023 13:51
d837059
to
b89d33c
Compare
missylbytes
force-pushed
the
backport/net-5164-update-docs-with-passive-health-check/curiously-eminent-mammoth
branch
from
September 22, 2023 14:58
b89d33c
to
84e0e77
Compare
…18532) Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
missylbytes
force-pushed
the
backport/net-5164-update-docs-with-passive-health-check/curiously-eminent-mammoth
branch
from
September 22, 2023 15:09
84e0e77
to
4d8ea21
Compare
blake
reviewed
Sep 22, 2023
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
missylbytes
deleted the
backport/net-5164-update-docs-with-passive-health-check/curiously-eminent-mammoth
branch
September 22, 2023 17:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18532 to be assessed for backporting due to the inclusion of the label backport/1.16.
🚨
The person who merged in the original PR is:
@missylbytes
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
Adds documentation for the PassiveHealthCheck field for ServiceDefaults and IngressGateway.
Testing & Reproduction steps
Note will add the backport label for 1.16 when the consul-k8s patch releases for 1.2.2 is done.
Links
PR Checklist
Overview of commits