Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workload identity hooks #19045

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Add workload identity hooks #19045

merged 3 commits into from
Oct 4, 2023

Conversation

kisunji
Copy link
Contributor

@kisunji kisunji commented Oct 3, 2023 •
edited
Loading

Description

Will add tenanted tests in a followup PR

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@vercel
Copy link

vercel bot commented Oct 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
consul ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2023 9:45pm
consul-ui-staging ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2023 9:45pm

@kisunji kisunji requested a review from ishustava October 3, 2023 16:39
@kisunji kisunji added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Oct 3, 2023
@kisunji kisunji requested review from a team, roncodingenthusiast and skpratt and removed request for a team October 3, 2023 16:40
cthain
cthain reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@cthain cthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a drive by. Left a few comments around boundary checking. Otherwise, LGTM.

@kisunji kisunji enabled auto-merge (squash) October 3, 2023 21:44
@kisunji kisunji merged commit b43cde5 into main Oct 4, 2023
@kisunji kisunji deleted the kisunji/workload-identity-hooks branch October 4, 2023 14:24
jmurret pushed a commit that referenced this pull request Oct 5, 2023
@jmurret
Add workload identity hooks (#19045)
9350c9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthain cthain cthain left review comments

@ishustava ishustava ishustava approved these changes

@roncodingenthusiast roncodingenthusiast Awaiting requested review from roncodingenthusiast

@skpratt skpratt Awaiting requested review from skpratt

Assignees
No one assigned
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kisunji @roncodingenthusiast @ishustava @cthain