Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chor: update rule to run frontend github tasks when changes are made … #19053

Merged
merged 2 commits into from
Oct 4, 2023
Merged

chor: update rule to run frontend github tasks when changes are made … #19053

merged 2 commits into from
Oct 4, 2023

Conversation

valeriia-ruban
Copy link
Contributor

@valeriia-ruban valeriia-ruban commented Oct 4, 2023 •
edited
Loading

…in ui folder

Description

Update rule for running frontend github actions when changes are done for ui folder.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@vercel
Copy link

vercel bot commented Oct 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
consul ⬜️ Ignored (Inspect) Oct 4, 2023 4:48am
consul-ui-staging ⬜️ Ignored (Inspect) Oct 4, 2023 4:48am

@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Oct 4, 2023
@valeriia-ruban valeriia-ruban added the pr/no-changelog PR does not need a corresponding .changelog entry label Oct 4, 2023
@valeriia-ruban valeriia-ruban added backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. labels Oct 4, 2023
@valeriia-ruban valeriia-ruban marked this pull request as ready for review October 4, 2023 04:59
WenInCode
WenInCode approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@WenInCode WenInCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@valeriia-ruban valeriia-ruban merged commit 344f463 into main Oct 4, 2023
87 checks passed
@valeriia-ruban valeriia-ruban deleted the edit-run-frontend-task-on-change-to-ui-folder branch October 4, 2023 20:15
This was referenced Oct 4, 2023
Merged
Merged
jmurret pushed a commit that referenced this pull request Oct 5, 2023
@valeriia-ruban @jmurret
chor: update rule to run frontend github tasks when changes are made … (
d8eb191 
#19053)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenInCode WenInCode WenInCode approved these changes

@chris-hut chris-hut Awaiting requested review from chris-hut

@natmegs natmegs Awaiting requested review from natmegs

@kaxcode kaxcode Awaiting requested review from kaxcode

@ellacai ellacai Awaiting requested review from ellacai

Assignees
No one assigned
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. pr/no-changelog PR does not need a corresponding .changelog entry theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valeriia-ruban @WenInCode