Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: when the v2 catalog experiment is enabled reject api and rpc requests that are for the v1 catalog #19129

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Oct 10, 2023

Description

When the v2 catalog experiment is enabled the old v1 catalog apis will be forcibly disabled at both the API (json) layer and the RPC (msgpack) layer. This will also disable anti-entropy as it uses the v1 api.

This includes all of /v1/catalog/*, /v1/health/*, most of /v1/agent/*, /v1/config/*, and most of /v1/internal/*.

NET-5581

@rboyer rboyer added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test pr/no-backport labels Oct 10, 2023
@rboyer rboyer self-assigned this Oct 10, 2023
@rboyer rboyer requested a review from a team as a code owner October 10, 2023 20:16
@github-actions github-actions bot added the theme/health-checks Health Check functionality label Oct 10, 2023
@rboyer rboyer force-pushed the rboyer/reject-v1-catalog branch from 531cc0c to 14263bd Compare October 10, 2023 22:05
agent/consul/server.go Outdated Show resolved Hide resolved
Copy link
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice work! thank you for putting this together so efficiently!

@rboyer rboyer merged commit b9ab63c into main Oct 11, 2023
84 checks passed
@rboyer rboyer deleted the rboyer/reject-v1-catalog branch October 11, 2023 15:44
jmurret pushed a commit that referenced this pull request Oct 12, 2023
…requests that are for the v1 catalog (#19129)

When the v2 catalog experiment is enabled the old v1 catalog apis will be
forcibly disabled at both the API (json) layer and the RPC (msgpack) layer.
This will also disable anti-entropy as it uses the v1 api.

This includes all of /v1/catalog/*, /v1/health/*, most of /v1/agent/*,
/v1/config/*, and most of /v1/internal/*.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test theme/health-checks Health Check functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants