NET-5951 - Unique route names for implicit routes #19174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmurret
added
pr/no-changelog
jmurret
force-pushed
the
jm/NET-5951
branch
3 times, most recently
from
aaf5a3a to
e782594
Compare
erichaberkorn
approved these changes
Oct 12, 2023
internal/mesh/internal/controllers/sidecarproxy/builder/destinations.go
Outdated
Show resolved
Hide resolved
ndhanushkodi
approved these changes
Oct 12, 2023
internal/mesh/internal/controllers/sidecarproxy/builder/naming.go
Outdated
Show resolved
Hide resolved
jmurret
added
backport/1.17
4 tasks
jmurret
added a commit
that referenced
this pull request
Oct 13, 2023
* NET-5951 - Unique route names for implicit routes * remove use of datacenter * PR feedback
jmurret
added a commit
that referenced
this pull request
Oct 13, 2023
* NET-5951 - Unique route names for implicit routes * remove use of datacenter * PR feedback
jmurret
added a commit
that referenced
this pull request
Oct 13, 2023
…lease/1.17.x (#19196) * no-op commit due to failed cherry-picking * NET-5951 - Unique route names for implicit routes (#19174) * NET-5951 - Unique route names for implicit routes * remove use of datacenter * PR feedback --------- Co-authored-by: temp <temp@hashicorp.com> Co-authored-by: John Murret <john.murret@hashicorp.com>
ndhanushkodi
pushed a commit
that referenced
this pull request
Oct 13, 2023
* NET-5951 - Unique route names for implicit routes * remove use of datacenter * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing & Reproduction steps
Links
PR Checklist