Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of mesh: add computed destinations with a controller that computes them into release/1.17.x #19194

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Backport of mesh: add computed destinations with a controller that computes them into release/1.17.x #19194

merged 1 commit into from
Oct 13, 2023

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19067 to be assessed for backporting due to the inclusion of the label backport/1.17.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@ishustava
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.

Description

This PR adds a new type ComputedDestinations that will contain all destinations from any Destinations resources and will be name-aligned with a workload. This also adds an explicit-destinations controller that computes these resources.

This is needed to simplify the tracking we need to do currently in the sidecar-proxy controller and makes it easier to query all explicit destinations that apply to a workload.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/ishustava/NET-3996-computed-destinations/lately-flowing-jaybird branch 2 times, most recently from cb3c976 to fe23230 Compare October 13, 2023 16:43
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added type/docs Documentation needs to be created/updated/clarified theme/api Relating to the HTTP API interface theme/health-checks Health Check functionality theme/cli Flags and documentation for the CLI interface type/ci Relating to continuous integration (CI) tooling for testing or releases theme/envoy/xds Related to Envoy support theme/contributing Additions and enhancements to community contributing materials labels Oct 13, 2023
@vercel vercel bot temporarily deployed to Preview – consul October 13, 2023 16:49 Inactive
@ishustava
mesh: add computed destinations with a controller that computes them (#…
082a3ef 
…19067)

This commit adds a new type ComputedDestinations that will contain all destinations from any Destinations resources and will be name-aligned with a workload. This also adds an explicit-destinations controller that computes these resources.

This is needed to simplify the tracking we need to do currently in the sidecar-proxy controller and makes it easier to query all explicit destinations that apply to a workload.
@ishustava ishustava force-pushed the backport/ishustava/NET-3996-computed-destinations/lately-flowing-jaybird branch from 5e932be to 082a3ef Compare October 13, 2023 16:57
@ishustava ishustava marked this pull request as ready for review October 13, 2023 16:58
@ishustava ishustava requested a review from a team as a code owner October 13, 2023 16:58
@ishustava ishustava enabled auto-merge (squash) October 13, 2023 16:59
@ishustava ishustava merged commit 71cb64b into release/1.17.x Oct 13, 2023
@ishustava ishustava deleted the backport/ishustava/NET-3996-computed-destinations/lately-flowing-jaybird branch October 13, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishustava ishustava ishustava approved these changes

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

Assignees

@ishustava ishustava

Labels
theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface theme/contributing Additions and enhancements to community contributing materials theme/envoy/xds Related to Envoy support theme/health-checks Health Check functionality type/ci Relating to continuous integration (CI) tooling for testing or releases type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc-github-team-consul-core @ishustava @github-team-consul-core-pr-approver