Backport of catalog, mesh: implement missing ACL hooks into release/1.17.x #19212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/ishustava/NET-3993-catalog-acls/mentally-sharing-ocelot
branch
from
f8e5bda to
2778f68
Compare
hc-github-team-consul-core
force-pushed
the
backport/ishustava/NET-3993-catalog-acls/mentally-sharing-ocelot
branch
from
8b70f57 to
8352527
Compare
github-team-consul-core-pr-approver
approved these changes
Oct 13, 2023
github-actions
bot
added
the
theme/cli
This change adds ACL hooks to the remaining catalog and mesh resources, excluding any computed ones. Those will for now continue using the default operator:x permissions. It refactors a lot of the common testing functions so that they can be re-used between resources. There are also some types that we don't yet support (e.g. virtual IPs) that this change adds ACL hooks to for future-proofing.
ishustava
force-pushed
the
backport/ishustava/NET-3993-catalog-acls/mentally-sharing-ocelot
branch
from
8352527 to
0a02b1f
Compare
hc-github-team-consul-core
deleted the
backport/ishustava/NET-3993-catalog-acls/mentally-sharing-ocelot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19143 to be assessed for backporting due to the inclusion of the label backport/1.17.
The below text is copied from the body of the original PR.
Description
This PR adds ACL hooks to the remaining catalog and mesh resources, excluding any computed ones. Those will for now continue using the default
operator:xpermissions.It refactors a lot of the common testing functions so that they can be re-used between resources.
There are also some types that we don't yet support (e.g. virtual IPs) that I've added ACL hooks to for future-proofing.
Testing & Reproduction steps
Links
PR Checklist
Overview of commits