Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of docs: Multi-port corrections into release/1.17.x #19228

Closed
wants to merge 3 commits into from
Closed

Backport of docs: Multi-port corrections into release/1.17.x #19228

wants to merge 3 commits into from

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19224 to be assessed for backporting due to the inclusion of the label backport/1.17.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@boruszak
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "31d2af6823c645bef6d3591fa38800553bc1d66d", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.

Description

Minor corrections to fix typos and shell commands.

Links

Deployment preview links:

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/initial-multiport-fixes/constantly-thorough-pheasant branch from f32af5d to 6f9ee70 Compare October 16, 2023 20:52
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/initial-multiport-fixes/constantly-thorough-pheasant branch from 5e589a8 to 84ccd32 Compare October 16, 2023 20:52
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Oct 16, 2023
@vercel vercel bot temporarily deployed to Preview – consul October 16, 2023 21:04 Inactive
@boruszak
Copy link
Contributor

Backport manually merged in #19229

@boruszak boruszak closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@boruszak boruszak Awaiting requested review from boruszak

Assignees

@boruszak boruszak

Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc-github-team-consul-core @boruszak @github-team-consul-core-pr-approver