Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of CC-6137 to release 1.17.x #19361

Closed
wants to merge 1 commit into from
Closed

Backport of CC-6137 to release 1.17.x #19361

wants to merge 1 commit into from

Conversation

WenInCode
Copy link
Contributor

Description

Manual backport of changes made in #19252 to release/1.17.x

The original backport looks to have gotten caught up in the backport backlog when they were disabled during the cutting of the ga branch and subsequently removed from the merged code in this PR: #19350

Manually backporting it into the release/1.17.x branch

Testing & Reproduction steps

Links

Original PR
Failed backport

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@chris-hut @ellacai
Upgrade Consul UI to Node 18 (#19252)
acf1df2 
* Upgrading node to node 18

* Ensure we're on latest version of yarn as well

* add comma to make frontend tests run

* Use Node 18 Alpine image in UI build dockerfile

* delete package-lock.json

---------

Co-authored-by: wenincode <tyler.wendlandt@hashicorp.com>
Co-authored-by: Ella Cai <ella.y.cai@gmail.com>
Co-authored-by: Ella Cai <ella@hashicorp.com>
@WenInCode WenInCode added theme/ui Anything related to the UI type/ci Relating to continuous integration (CI) tooling for testing or releases pr/dependencies PR specifically updates dependencies of project labels Oct 25, 2023
@WenInCode WenInCode requested a review from a team as a code owner October 25, 2023 13:43
@WenInCode WenInCode requested a review from a team October 25, 2023 13:43
@WenInCode WenInCode requested review from a team as code owners October 25, 2023 13:43
@WenInCode WenInCode requested review from dekimsey and claire-labry and removed request for a team October 25, 2023 13:43
@github-actions github-actions bot added type/docs Documentation needs to be created/updated/clarified theme/api Relating to the HTTP API interface theme/acls ACL and token generation theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/envoy/xds Related to Envoy support theme/contributing Additions and enhancements to community contributing materials labels Oct 25, 2023
@WenInCode WenInCode changed the base branch from main to release/1.17.x October 25, 2023 13:44
@WenInCode WenInCode closed this Oct 25, 2023
@WenInCode WenInCode deleted the backport/ui/CC-6137-to-release-1.17.x branch October 25, 2023 13:45
@WenInCode WenInCode restored the backport/ui/CC-6137-to-release-1.17.x branch October 25, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekimsey dekimsey Awaiting requested review from dekimsey

@claire-labry claire-labry Awaiting requested review from claire-labry

Assignees
No one assigned
Labels
pr/dependencies PR specifically updates dependencies of project theme/acls ACL and token generation theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/contributing Additions and enhancements to community contributing materials theme/envoy/xds Related to Envoy support theme/ui Anything related to the UI type/ci Relating to continuous integration (CI) tooling for testing or releases type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WenInCode @chris-hut