Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix casing in example yaml config into release/1.13.x #19404

Conversation

hc-github-team-consul-core
Copy link
Contributor

@hc-github-team-consul-core hc-github-team-consul-core commented Oct 27, 2023

Backport

This PR is auto-generated from #19369 to be assessed for backporting due to the inclusion of the label backport/1.13.

The below text is copied from the body of the original PR.


Description

This page in the docs has example code that is copy-pastable; however, it has a casing error which prevents the copied code from working for Kubernetes:

error: error validating "cluster-2/exported-services.yaml": error validating data: kind not set; if you choose to ignore these errors, turn validation off with --validate=false

Testing & Reproduction steps

Copy-paste the modified examples and attempt to apply them to a Kubernetes cluster using kubectl apply -f <filename>. Verify the command completes successfully instead of returning the above error.

Links

Page containing broken example code

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 27, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul October 27, 2023 14:20 Inactive
@nathancoleman nathancoleman force-pushed the backport/nathancoleman-patch-1/hopelessly-wired-terrier branch from c888fe1 to 4211867 Compare October 27, 2023 19:05
@nathancoleman nathancoleman marked this pull request as ready for review October 27, 2023 19:06
@nathancoleman nathancoleman requested a review from a team as a code owner October 27, 2023 19:06
@nathancoleman nathancoleman enabled auto-merge (squash) October 27, 2023 19:06
@nathancoleman
Copy link
Member

Going ahead and merging since license-check isn't running on this branch. Manual inspection shows that there are no copyright header changes included in this PR.

@nathancoleman nathancoleman merged commit 4f1d357 into release/1.13.x Oct 27, 2023
94 checks passed
@nathancoleman nathancoleman deleted the backport/nathancoleman-patch-1/hopelessly-wired-terrier branch October 27, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants