Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix casing in example yaml config into release/1.17.x #19408

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #19369 to be assessed for backporting due to the inclusion of the label backport/1.17.

The below text is copied from the body of the original PR.


Description

This page in the docs has example code that is copy-pastable; however, it has a casing error which prevents the copied code from working for Kubernetes:

error: error validating "cluster-2/exported-services.yaml": error validating data: kind not set; if you choose to ignore these errors, turn validation off with --validate=false

Testing & Reproduction steps

Copy-paste the modified examples and attempt to apply them to a Kubernetes cluster using kubectl apply -f <filename>. Verify the command completes successfully instead of returning the above error.

Links

Page containing broken example code

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/nathancoleman-patch-1/promptly-stirring-porpoise branch from b7055a0 to cfe5b26 Compare October 27, 2023 14:15
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/nathancoleman-patch-1/promptly-stirring-porpoise branch from e0df669 to c58cebf Compare October 27, 2023 14:15
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Oct 27, 2023
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core hc-github-team-consul-core merged commit fb80da2 into release/1.17.x Oct 27, 2023
49 of 50 checks passed
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/nathancoleman-patch-1/promptly-stirring-porpoise branch October 27, 2023 14:23
@vercel vercel bot temporarily deployed to Preview – consul October 27, 2023 14:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants