ui: 1.16.x Back to HCP link conditions #19443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenInCode
changed the title
WenInCode
force-pushed
the
ui/1-16/back-to-hcp-link-conditions
branch
from
e555337
to
b9e4ba0
Compare
WenInCode
force-pushed
the
ui/1-16/back-to-hcp-link-conditions
branch
from
b9e4ba0
to
f2c86c8
Compare
chris-hut
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the back to hcp link will show whenever
CONSUL_HCP_ENABLEis set. However, there are times when theCONSUL_HCP_URLis not present. My understanding is this could be if you visit the UI directly without accessing it via HCP UI? Either way, we should only show the link if the value is present.This is handled will be handled in the new sidenav on
mainand1.17.xvia the side nav updates PR (#19342 ). I am manually backporting this change to 1.16 and 1.15 because of that.Testing & Reproduction steps
Scenario('CONSUL_HCP_ENABLE', 1)in the browser console to enable HCP modeScenario('CONSUL_HCP_URL', 'url of your choice')in the browser console to set the HCP url.Links
PR Checklist