Backport of testing/deployer: update deployer to use v2 catalog constructs when requested into release/1.17.x #19492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
requested review from
dekimsey and
randyhdev
and removed request for
a team
hc-github-team-consul-core
force-pushed
the
backport/rboyer/deployer-catalog-v2/typically-handy-seasnail
branch
2 times, most recently
from
a8ff8ec to
6ef72fd
Compare
github-team-consul-core-pr-approver
approved these changes
Nov 2, 2023
github-actions
bot
added
type/docs
…equested (#19046) This updates the testing/deployer (aka "topology test") framework to conditionally configure and launch catalog constructs using v2 resources. This is controlled via a Version field on the Node construct in a topology.Config. This only functions for a dataplane type and has other restrictions that match the rest of v2 (no peering, no wanfed, no mesh gateways). Like config entries, you can statically provide a set of initial resources to be synced when bringing up the cluster (beyond those that are generated for you such as workloads, services, etc). If you want to author a test that can be freely converted between v1 and v2 then that is possible. If you switch to the multi-port definition on a topology.Service (aka "workload/instance") then that makes v1 ineligible. This also adds a starter set of "on every PR" integration tests for single and multiport under test-integ/catalogv2
rboyer
force-pushed
the
backport/rboyer/deployer-catalog-v2/typically-handy-seasnail
branch
from
6ef72fd to
2779a2e
Compare
hc-github-team-consul-core
deleted the
backport/rboyer/deployer-catalog-v2/typically-handy-seasnail
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19046 to be assessed for backporting due to the inclusion of the label backport/1.17.
The below text is copied from the body of the original PR.
Description
This updates the
testing/deployer(aka "topology test") framework to conditionally configure and launch catalog constructs using v2 resources. This is controlled via aVersionfield on theNodeconstruct in atopology.Config. This only functions for a dataplane type and has other restrictions that match the rest of v2 (no peering, no wanfed, no mesh gateways).Like config entries, you can statically provide a set of initial resources to be synced when bringing up the cluster (beyond those that are generated for you such as workloads, services, etc).
If you want to author a test that can be freely converted between v1 and v2 then that is possible. If you switch to the multi-port definition on a
topology.Service(aka "workload/instance") then that makes v1 ineligible.This also adds a starter set of "on every PR" integration tests for single and multiport under
test-integ/catalogv2NET-5734
Overview of commits