Backport of test: update certs for 10 year expiry into release/1.15.x #19559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/dans/NET-6450/update-cert-for-10-years/firmly-helpful-weevil
branch
from
9195cd6 to
ddcbe27
Compare
hc-github-team-consul-core
force-pushed
the
backport/dans/NET-6450/update-cert-for-10-years/firmly-helpful-weevil
branch
from
6a37218 to
1b8c2ee
Compare
github-actions
bot
added
theme/cli
github-team-consul-core-pr-approver
approved these changes
Nov 7, 2023
hc-github-team-consul-core
merged commit d79540b
into
release/1.15.x
85 of 86 checks passed
hc-github-team-consul-core
deleted the
backport/dans/NET-6450/update-cert-for-10-years/firmly-helpful-weevil
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19481 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Description
Updates to make sure that test certs expire after ~10 years. I also noticed some root CAs will expire in the next couple of years, so those are also updated.
There is one remaining cert that expires < 5 years,
./test/ca_path/cert1.crt. I didn't know off the top of my head how to replicate the error case, so we will revisit in 2025?Testing & Reproduction steps
Tests are run in CI.
PR Checklist
Overview of commits