-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in GatewayClassConfig docs #19563
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,8 +28,8 @@ The following outline shows how to format the configurations in the `GatewayClas | |
* [`grpc`](#consul-ports-grpc): integer | optional | ||
* [`http`](#consul-ports-http): integer | optional | ||
* [`scheme`](#consul-scheme): string | optional | ||
* [`copyAnnotations`](#copyAnnotations): object | optional | ||
* [`service`](#copyAnnotations-service): array of strings | optional | ||
* [`copyAnnotations`](#copyannotations): object | optional | ||
* [`service`](#copyannotations-service): array of strings | optional | ||
* [`deployment`](#deployment): object | optional | ||
* [`defaultInstances`](#deployment-defaultinstances): integer | optional | ||
* [`maxInstances`](#deployment-maxinstances): integer | optional | ||
|
@@ -38,9 +38,9 @@ The following outline shows how to format the configurations in the `GatewayClas | |
* [`consulAPIGateway`](#image-consulapigateway): string | optional | ||
* [`envoy`](#image-envoy): string | optional | ||
* [`logLevel`](#loglevel): string | optional | ||
* [`matchPrivilegedContainerPorts`](#matchPrivilegedContainerPorts): integer | optional | ||
* [`mapPrivilegedContainerPorts`](#mapprivilegedcontainerports): integer | optional | ||
* [`nodeSelector`](#nodeselector): string | optional | ||
* [`openshiftSCCName`](#openshiftSCCName): string | optional | ||
* [`openshiftSCCName`](#openshiftsccname): string | optional | ||
* [`serviceType`](#servicetype): string | optional | ||
* [`useHostPorts`](#usehostports): boolean | optional | ||
|
||
|
@@ -154,8 +154,8 @@ You can specify the following strings: | |
* `debug` | ||
* `trace` | ||
|
||
### matchPrivilegedContainerPorts | ||
Specifies a value that Consul adds to privileged ports defined in the gateway. Privileged ports are port numbers less than 1024 and some platforms, such as Red Hat OpenShift, explicitly configure Kubernetes to avoid running containers on privileged ports. The total value of the configured port number and the `matchPriviledgedContainerPorts` value must not exceed 65535, which is the highest possible TCP port number allowed. | ||
### mapPrivilegedContainerPorts | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The name of this field is |
||
Specifies a value that Consul adds to privileged ports defined in the gateway. Privileged ports are port numbers less than 1024 and some platforms, such as Red Hat OpenShift, explicitly configure Kubernetes to avoid running containers on privileged ports. The total value of the configured port number and the `mapPriviledgedContainerPorts` value must not exceed 65535, which is the highest possible TCP port number allowed. | ||
for gateway containers | ||
* Type: Integer | ||
* Required: optional | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links targeting anything that isn't all lowercase are currently broken since the casing needs to match the generated anchor for each header, so I fixed those