Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of test: add a v2 container integration test of xRoute splits into release/1.17.x #19587

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19570 to be assessed for backporting due to the inclusion of the label backport/1.17.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@rboyer
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

This adds a deployer-based integration test verifying that a 90/10 traffic split works for: HTTPRoute, GRPCRoute, and TCPRoute.

Ordinarily we would use fortio to verify the destinations reached during the test, but there wasn't a good way to exploit its gRPC ping service to unearth the original app identity, so for now I wrote a quick server to reply in a protocol-specific way with a user-defined name that works for http, http2, grpc, and plain tcp: https://github.com/rboyer/blankspace


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/rboyer/deployer-l7-split-tests/grossly-advanced-boa branch from da2a572 to b19e975 Compare November 8, 2023 23:20
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/rboyer/deployer-l7-split-tests/grossly-advanced-boa branch from b19e975 to da2a572 Compare November 8, 2023 23:20
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

…19570)

This adds a deployer-based integration test verifying that a 90/10 traffic
split works for: HTTPRoute, GRPCRoute, and TCPRoute.
@rboyer rboyer force-pushed the backport/rboyer/deployer-l7-split-tests/grossly-advanced-boa branch from d7cf1d7 to 01c5960 Compare November 8, 2023 23:23
@rboyer rboyer marked this pull request as ready for review November 8, 2023 23:23
@rboyer rboyer enabled auto-merge (squash) November 8, 2023 23:23
@rboyer rboyer merged commit 9ee5956 into release/1.17.x Nov 8, 2023
88 checks passed
@rboyer rboyer deleted the backport/rboyer/deployer-l7-split-tests/grossly-advanced-boa branch November 8, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants