Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/UI/feature/make global read only policy non editable/instantly hardy chamois 2 #19623

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Backport/UI/feature/make global read only policy non editable/instantly hardy chamois 2 #19623

merged 6 commits into from
Nov 14, 2023

Conversation

valeriia-ruban
Copy link
Contributor

@valeriia-ruban valeriia-ruban commented Nov 14, 2023 •
edited
Loading

Description

PR is manually created to backport #18602

image

Testing & Reproduction steps

  1. set up CONSUL_ACLS_ENABLE to 1 in session storage
  2. set CONSUL_POLICY_COUNT = 10
  3. go to Policies
  4. log in with any securId
  5. check list of items to see global-read-only policy
  6. go to the policy details and check that form is non-editable

Links

JIRA
Figma

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@valeriia-ruban valeriia-ruban added theme/ui Anything related to the UI pr/no-backport labels Nov 14, 2023
@kaxcode kaxcode self-requested a review November 14, 2023 19:22
kaxcode
kaxcode approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport approved

@valeriia-ruban valeriia-ruban merged commit 407a41e into release/1.15.x Nov 14, 2023
69 checks passed
@valeriia-ruban valeriia-ruban deleted the backport/ui/feature/make-global-read-only-policy-non-editable/instantly-hardy-chamois-2 branch November 14, 2023 20:02
@jira jira bot mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaxcode kaxcode kaxcode approved these changes

Assignees
No one assigned
Labels
pr/no-backport theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valeriia-ruban @kaxcode