Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-6900: stop reconciling services when peering is enabled #19907

Merged
merged 1 commit into from
Dec 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/19907.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
ui: stop manually reconciling services if peering is enabled
```
11 changes: 11 additions & 0 deletions ui/packages/consul-ui/app/services/repository.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,17 @@ export default class RepositoryService extends Service {
return false;
}
}

// We were seeing issues where services were all being unloaded after visiting
// a peers imported services page. So if you viewes services -> peered imported services -> services
// only the peered services would remain as the others were all unloaded. Not certain if
// we should be doing any manual reconciling as it is. Not enough historical context
// to determine that at this time.
//
// https://hashicorp.atlassian.net/browse/NET-6900
if (this.env.var('CONSUL_PEERINGS_ENABLED') && this.getModelName() === 'service') {
return false;
}
return true;
}

Expand Down
Loading