Fix Transparent Proxy Block in Read

[absolutelightning]

Description

When we create a service default using the following data

Kind = "service-defaults"
Name = "sd"
Protocol = "tcp"
Destination {
  Addresses = ["test.com","test.org"]
  Port = 443
}

Currently when we read the config entry back - we get

{
    "Kind": "service-defaults",
    "Name": "sd",
    "Protocol": "tcp",
    "TransparentProxy": {},
    "MeshGateway": {},
    "Expose": {},
    "Destination": {
        "Addresses": [
            "test.com",
            "test.org"
        ],
        "Port": 443
    },
    "CreateIndex": 18,
    "ModifyIndex": 18
}

Notice the transparent proxy block introduced with blank values.

With this change in PR - we get

{
    "Kind": "service-defaults",
    "Name": "sd",
    "Protocol": "tcp",
    "MeshGateway": {},
    "Expose": {},
    "Destination": {
        "Addresses": [
            "test.com",
            "test.org"
        ],
        "Port": 443
    },
    "CreateIndex": 18,
    "ModifyIndex": 18
}

The response is decoded in consul terraform provider and we get default values of int OutboundListenerPort -> 0 and bool DialedDirectly -> false, there. which is causing issue. We are using json decode in consul terraform provider.

Testing & Reproduction steps

CI

PR Checklist

• updated test coverage
• external facing docs updated
• appropriate backport labels added
• not a security concern

[Ganeshrockz]

Any specific reason you can't handle this in the provider's logic? I see other fields returning non pointer fields and I guess this was done like to make sure to not perform nil checks in downstream dependencies.

[absolutelightning]

The response is decoded in consul terraform provider and we get default values of int OutboundListenerPort -> 0 and bool DialedDirectly -> false, there. which is causing issue. We are using json decode in consul terraform provider.

The response is decoded in consul terraform provider and we get default values of int OutboundListenerPort -> 0 and bool DialedDirectly -> false, there. which is causing issue. We are using json decode in consul terraform provider.

[github-actions]

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

[github-actions]

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.