-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Transparent Proxy Block in Read #20179
Conversation
Any specific reason you can't handle this in the provider's logic? I see other fields returning non pointer fields and I guess this was done like to make sure to not perform |
The response is decoded in consul terraform provider and we get default values of int OutboundListenerPort -> 0 and bool DialedDirectly -> false, there. which is causing issue. We are using json decode in consul terraform provider. |
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review. |
Description
When we create a service default using the following data
Currently when we read the config entry back - we get
Notice the transparent proxy block introduced with blank values.
With this change in PR - we get
The response is decoded in consul terraform provider and we get default values of int
OutboundListenerPort
-> 0 and boolDialedDirectly
-> false, there. which is causing issue. We are using json decode in consul terraform provider.Testing & Reproduction steps
CI
PR Checklist